feat(cascader): support custom options #INFR-12126 #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
minlovehua
reviewed
Apr 11, 2024
src/cascader/cascader.service.ts
Outdated
| return; | ||
| } | ||
|
|
||
| let selectedCustomOpts = this.getSelectedCustomOpts(); |
There was a problem hiding this comment.
变量名尽量写全，不要缩写。（见Wiki页面 前端代码编程规范）
单元测试里同理。
|
|
||
| public values: SafeAny[] = ['all']; | ||
|
|
||
| public singleValues: any[] = ['12', '1201', '120102']; |
There was a problem hiding this comment.
SafeAny 和 any 统一用其中一个。 一般情况下建议指定具体类型
minlovehua
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.