This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
4.3 #735
Closed
4.3 #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct model to be performed on here
romaninsh
reviewed
Jun 23, 2017
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "name": "atk4/atk4", | |||
| "name": "xepan/atk4", | |||
There was a problem hiding this comment.
this change is probably a mistake.
There was a problem hiding this comment.
yep ... :) sure it is ... there are a lot of things i didn't wanted to push
romaninsh
reviewed
Jun 23, 2017
| @@ -349,7 +349,7 @@ function verifyCredentials($user, $password) | |||
| // Attempt to load user data by username. If not found, return | |||
| // false | |||
|
|
|||
| $data = $this->model->newInstance()->tryLoadBy($this->login_field, $user); | |||
| $data = $this->model->tryLoadBy($this->login_field, $user); | |||
There was a problem hiding this comment.
riskier than original, why exactly the change?
romaninsh
reviewed
Jun 23, 2017
| @@ -132,7 +132,7 @@ function parseRequestedURL(){ | |||
| if($https)$url.='s'; | |||
|
|
|||
| // 2. Continue building. We are adding hostname next and port. | |||
| $url .= "://".$_SERVER["SERVER_NAME"]; | |||
| $url .= "://".$_SERVER["HTTP_HOST"]; | |||
There was a problem hiding this comment.
will this still work with apache?
There was a problem hiding this comment.
This was only change i wanted to push btw 😆
romaninsh
reviewed
Jun 23, 2017
| $template=$this->template->cloneRegion('field_input'); | ||
| $options['show_input_only']=true; | ||
| if ($insert_into->template->hasTag($name)) { | ||
| if($this->app->getConfig('form/layout/inputonly',true)){ |
There was a problem hiding this comment.
seems like some hard-code thing.
romaninsh
reviewed
Jun 23, 2017
| // 'addons'=>'addons', | ||
| // 'template'=>$templates_folder, | ||
| // ))->setBasePath(dirname($base_directory).'/shared'); | ||
| // } | ||
|
|
There was a problem hiding this comment.
also, probably to big of a change for legacy projects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx Does not throw dynamic subdomain, $app->url()->absolute()->getBaseURL() will show main server_name set in nginx configuration only. HTTP_HOST is better option.