Skip to content

Commit

Permalink
We need TrackableTrait for Model
Browse files Browse the repository at this point in the history
Otherwise there will be collisions because of $name property when we create extended class which needs TrackableTrait (to use in toolkit).
  • Loading branch information
DarkSide666 committed Aug 2, 2016
1 parent f1baf54 commit 01d00f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Model.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
class Model implements \ArrayAccess, \IteratorAggregate
{
use \atk4\core\ContainerTrait;
use \atk4\core\TrackableTrait;
use \atk4\core\DynamicMethodTrait;
use \atk4\core\HookTrait;
use \atk4\core\InitializerTrait {
init as _init;
}
use \atk4\core\NameTrait;

// {{{ Properties of the class

Expand Down

1 comment on commit 01d00f7

@romaninsh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with this change, i think it will kill the garbage collection as models will now all be tracked inside persistence. I think collisions should be resolved even with NameTrait. Also - so far i had no naming collisions either.

Please sign in to comment.