Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Reference::$model property protected #1180

Merged
merged 7 commits into from Mar 7, 2024
Merged

Make Reference::$model property protected #1180

merged 7 commits into from Mar 7, 2024

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Mar 7, 2024 •
edited

to enforce Reference::createTheirModel() usage

impact should be minimal as using Reference::$model directly is mostly wrong

@mvorisek mvorisek force-pushed the no_setdefaults_twice_in_reference branch from 78a4d99 to 0fe94b9 Compare March 7, 2024 11:08
@mvorisek mvorisek marked this pull request as ready for review March 7, 2024 11:26
@mvorisek mvorisek changed the title Do not set model defaults twice in Reference Make Reference::$model property protected Mar 7, 2024
@mvorisek mvorisek merged commit 5ef70ad into develop Mar 7, 2024
31 checks passed
@mvorisek mvorisek deleted the no_setdefaults_twice_in_reference branch March 7, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mvorisek