Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind PostgreSQL values using strong type #1217

Merged
merged 11 commits into from
May 19, 2024
Merged

Bind PostgreSQL values using strong type #1217

merged 11 commits into from
May 19, 2024

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented May 19, 2024

Fix pg_typeof(:a) throwing an exception:

SQLSTATE[42P08]: Ambiguous parameter: 7 ERROR:  could not determine data type of parameter $1

As of this PR citext PostgreSQL extension is required. The atk4/data will install the extension during the first SQL connection connect if not already installed, but CREATE DB priviledge is required.

This PR also highly improves testing quality as native DB types need to match the bound variable types.

@mvorisek mvorisek marked this pull request as ready for review May 19, 2024 16:14
@mvorisek mvorisek merged commit 3bc5dce into develop May 19, 2024
31 checks passed
@mvorisek mvorisek deleted the pgsql_always_cast branch May 19, 2024 17:06
@mvorisek mvorisek restored the pgsql_always_cast branch May 20, 2024 23:57
@mvorisek mvorisek deleted the pgsql_always_cast branch May 20, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant