Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix 256 #257

Merged
merged 2 commits into from Nov 17, 2017
Merged

Feature/fix 256 #257

merged 2 commits into from Nov 17, 2017

Conversation

romaninsh
Copy link
Member

fix for #256

@codecov
Copy link

codecov bot commented Nov 17, 2017

Codecov Report

Merging #257 into develop will increase coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #257      +/-   ##
=============================================
+ Coverage      77.77%   77.93%   +0.16%     
- Complexity       849      851       +2     
=============================================
  Files             16       16              
  Lines           1908     1940      +32     
=============================================
+ Hits            1484     1512      +28     
- Misses           424      428       +4
Impacted Files Coverage Δ Complexity Δ
src/Persistence.php 53.62% <0%> (ø) 79 <0> (ø) ⬇️
src/ValidationException.php 89.65% <0%> (-10.35%) 4% <0%> (-1%)
src/Reference_SQL_One.php 87.77% <0%> (+2.06%) 31% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1144ac0...35f544a. Read the comment docs.

@romaninsh romaninsh added the bug label Nov 17, 2017
@romaninsh
Copy link
Member Author

Because this issue is a bug, i'd merge it even if coverage is insufficient.

Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@DarkSide666 DarkSide666 merged commit 848e60a into develop Nov 17, 2017
@DarkSide666 DarkSide666 deleted the feature/fix-256 branch November 17, 2017 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants