works better with namespaces #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #295 +/- ##
=============================================
+ Coverage 78.99% 79.04% +0.05%
- Complexity 902 903 +1
=============================================
Files 17 17
Lines 1966 1966
=============================================
+ Hits 1553 1554 +1
+ Misses 413 412 -1
Continue to review full report at Codecov.
|
romaninsh
commented
Apr 17, 2018
| $class = get_class($this); | ||
| } elseif ($class instanceof self) { | ||
| $class = get_class($class); | ||
| $class = $this; |
There was a problem hiding this comment.
should be get_class($this);
There was a problem hiding this comment.
Yes this change looks bad now. Not sure what I was thinking about ...
fixed in #320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement namespace handling