Cleanups to make 0.5 release more stable #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
action 'field' should be easier to memorize.
no need to be compatible now..
romaninsh
changed the title
This was referenced Jul 6, 2016
Merged
| @@ -8,7 +8,7 @@ class Field_SQL_One extends Field_One | |||
| function addField($field, $their_field) | |||
| { | |||
| $this->owner->addExpression($field, function($m) use ($their_field) { | |||
| return $m->refLink($this->link)->action('fieldValues', [$their_field]); | |||
| return $m->refLink($this->link)->action('field', [$their_field]); | |||
There was a problem hiding this comment.
Definitely looks more clear this way
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ran into problems when recording tutorial, so I'm fixing those minor bugs and will release them in a next minor release.