Forward-Compatibility with #597 #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
requested changes
Jun 7, 2020
src/Model.php
Outdated
| public const HOOK_AFTER_SAVE = 'afterSave'; | ||
|
|
||
| /** @const string Executed when execution of self::atomic() failed. */ | ||
| public const HOOK_ROLLBACK = self::class . '@rollback'; |
There was a problem hiding this comment.
it will be also better to disable StyleCI. Everywhere
mvorisek
approved these changes
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a smooth transition into #597
This should work with v2.0 branch and your code will continue to work going into v2.1 branch.
Example Old Code
$model->addHook('beforeSave', function() {});
Example New code
$model->addHook(\atk4\data\Model::HOOK_BEFORE_SAVE, function() {});