Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model in ValidationExceptions #837

Merged
merged 2 commits into from Mar 3, 2021
Merged

Add model in ValidationExceptions #837

merged 2 commits into from Mar 3, 2021

Conversation

DarkSide666
Copy link
Member

No description provided.

@DarkSide666 DarkSide666 added the RTM label Mar 3, 2021
@mvorisek
Copy link
Member

mvorisek commented Mar 3, 2021

shouldn't we make the model parameter required then?

@DarkSide666
Copy link
Member Author

DarkSide666 commented Mar 3, 2021 •
edited

I didn't want to make some breaking changes. Theoretically field can exist without model. So I think this PR is good as it is.

Also theoretically possible that fields there could be from multiple models, because first argument can be array of fields=>errors.

@DarkSide666 DarkSide666 closed this Mar 3, 2021
@DarkSide666 DarkSide666 reopened this Mar 3, 2021
@DarkSide666 DarkSide666 merged commit 3b4396f into develop Mar 3, 2021
@DarkSide666 DarkSide666 deleted the feature/model-in-exceptions branch March 3, 2021 19:26
@mvorisek mvorisek removed their request for review March 3, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DarkSide666 @mvorisek