Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table\Column\FilterModel throws error on json type fields #1744

Closed
DarkSide666 opened this issue Mar 3, 2022 · 0 comments · Fixed by #1747
Closed

Table\Column\FilterModel throws error on json type fields #1744

DarkSide666 opened this issue Mar 3, 2022 · 0 comments · Fixed by #1747
Assignees
Labels

Comments

@DarkSide666
Copy link
Member

DarkSide666 commented Mar 3, 2022

If we have type=>json field in model and for some strange reason add it as column in grid and enable filtering, then Table\Column\FilterModel throws error

Critical Error
ErrorException: Undefined index: json

in vendor/atk4/ui/src/Table/Column/FilterModel.php:75

That's because filtering for this field type is not implemented and that's kind of understandable, but at least it shouldn't throw such ugly exception. Better would be to simply not add filtering in this column.

Probably same happens with fields type=>object and maybe enum and values type of data fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants