Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRUD does not open / show fields in IE #967

Closed
mvorisek opened this issue Feb 22, 2020 · 7 comments · Fixed by #1090
Closed

CRUD does not open / show fields in IE #967

mvorisek opened this issue Feb 22, 2020 · 7 comments · Fixed by #1090
Assignees
@ibelar
Labels
Compatibility help wanted MAJOR

Comments

@mvorisek
Copy link
Member

mvorisek commented Feb 22, 2020 •
edited

image

image

image

latest atk4/ui, IE 11 on Win 10 x64
@mvorisek mvorisek changed the title CRUD does not open in IE CRUD does not open / show fields in IE Feb 22, 2020
@mvorisek
Copy link
Member Author

How is the https://ui.agiletoolkit.org/ page deployed? Is it somehow automatized? It would be great if can be deployed directly from develop (or at least the latest stable version), so the some issues can be tested and/or referenced to this page.

@DarkSide666
Copy link
Member

https://ui.agiletoolkit.org/ should/will be automatically deployed in future. Actually there is script ready for that, but it's not finished. I hope @romaninsh will finish it at some point.

@DarkSide666
Copy link
Member

Yes it looks that IE11 is not supported. Edge works fine, but IE11 no because of JS errors seen above in scheenshot.

@mvorisek
Copy link
Member Author

older v1.7.1 works fine, see https://ui.agiletoolkit.org/demos/crud.php , there are probably no more than few JS lines which are not compatible and can be changed to make IE11 supported.

Help wanted.

@mvorisek mvorisek added the MAJOR label Apr 14, 2020
@mvorisek
Copy link
Member Author

@ibelar Do you think this can be easily fixed?

@ibelar
Copy link
Contributor

ibelar commented Apr 14, 2020

@mvorisek - Did you test recently? I might has been fix in latest js package release 1.12.4 and up by using latest corejs version 3. Can not test it on my side...

@mvorisek
Copy link
Member Author

The issue is still presented, here is a console log after https://ui3.agiletoolkit.org/demos/crud.php load and after clicking on "Add Country":

image

ibelar added a commit that referenced this issue Apr 14, 2020
@ibelar
[Fix] Issue #967
7607c65
@ibelar ibelar mentioned this issue Apr 14, 2020
Merged
DarkSide666 pushed a commit that referenced this issue Apr 14, 2020
@ibelar
[Fix] Issue #967 (#1090)
baadf00
DarkSide666 pushed a commit that referenced this issue Apr 14, 2020
@ibelar
[Feature] Right layout panel (#1085)
03f0ab2 
* init

* more test

* improvement

* refactor commit

* more ref

* more ref

* more ref

* cleanup

update comment and bug fixe

* improvement

bug fixes
css class rename

* Apply fixes from StyleCI

* reset js file name for production

* fix css media class name

* fix js file name

* add nice description to action

* init

* improvement

* Apply fixes from StyleCI

* test for dropdown effect on behat

* merge userconfirmation and behat test fix

* remove extra space

* fix tab handler

* increase callback wait time

* give time for tab to init

* increase wait time for tab to activated

* improve test speed by reducing page load

- using less scenario in order to reduce page load

* clean up

* [Fix] Issue #967

* update release

* update package

* fix useraction test

make sure page reload between scenario so toast content is properly clear

* more test fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibelar ibelar

Labels
Compatibility help wanted MAJOR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Issue #967 atk4/ui
3 participants
@DarkSide666 @ibelar @mvorisek