Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage of PR "Reorganize demos file" #1139

Merged
merged 3 commits into from Apr 26, 2020

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Apr 26, 2020

To fix only, not to revert

@ibelar there is something wrong this #1122 merged PR, please look at it

That PR dropped the coverage by more then 50%, see https://codecov.io/gh/atk4/ui/tree/75c4026c5199781fdd0c1ad831264a9b02806632

previous commit: https://codecov.io/github/atk4/ui/commit/804728b0ca9e3e05dcf0166bde9265063ee1b756 is fine, revert is also fine, so definitely the issue is that single PR

(links are from Travis 7.2 tests)

@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #1139 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1139   +/-   ##
==========================================
  Coverage      27.32%   27.32%           
  Complexity      2536     2536           
==========================================
  Files            130      130           
  Lines           6225     6225           
==========================================
  Hits            1701     1701           
  Misses          4524     4524           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c4026...82b6179. Read the comment docs.

Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@ibelar ibelar marked this pull request as ready for review April 26, 2020 22:28
@ibelar ibelar merged commit bde0d37 into develop Apr 26, 2020
@ibelar ibelar deleted the revert-1122-reorganise/demos branch April 26, 2020 22:28
@mvorisek
Copy link
Member Author

mvorisek commented Apr 26, 2020

Good catch! Thanks

@ibelar Thanks for the approval and even faster merge :), but changes are needed to fix this. Checks passed as the dropped coverage was not decreased further...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants