Add support for file drop for Upload control #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
mvorisek
force-pushed
the
fix_upload_drop
branch
2 times, most recently
from
138be25
to
abbe331
Compare
mvorisek
force-pushed
the
fix_upload_drop
branch
2 times, most recently
from
86834b0
to
a96fbc5
Compare
mvorisek
force-pushed
the
fix_upload_drop
branch
3 times, most recently
from
11f5abd
to
1fca8ab
Compare
|
@ibelar please test with Chrome and review. Covered area can be debug by setting non-zero visibility and some background color. |
mvorisek
force-pushed
the
fix_upload_drop
branch
2 times, most recently
from
7dc5aa9
to
3109b83
Compare
mvorisek
force-pushed
the
fix_upload_drop
branch
from
3109b83
to
421b493
Compare
|
Also tested on Chrome & Safari, merging, once FUI 2.9 is out, we can replace with native component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1379
tested with Firefox - /wo this PR - no file can be dropped, /w this PR - file can be dropped anywhere on the input text
UPDATE: supported now natively by Fomantic? fomantic/Fomantic-UI#2145