Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Js Atk Bundle eventBus #1435

Merged
merged 10 commits into from Sep 14, 2020
Merged

Refactor Js Atk Bundle eventBus #1435

merged 10 commits into from Sep 14, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Sep 2, 2020 •
edited

  • Create eventBus under atk namespace;
  • remove deprecated Vue eventBus (Vue v3)
  • remove deprecated inline-template (Vue v3)
  • Move options to atk-utils.js

Small BC- Break:

Emitting an event was done using a Vue Instance from the vue service. Support for emitting/responding to event from a Vue instance will be removed in V3.

Emitting/responding to event is now perform at the atk bundle level using mitt package.

Breaking part:

  • JsVueService::emitEvent() method has been remove completelly;
  • View::jsVueEmit() method has been replace by View::jsEmitEvent()

@ibelar
Refactor Js Atk Bundle
490a178 
- Create eventBus under atk namespace;
 - remove deprecated Vue eventBus ( will be remove in Vue v3)
- Move options to atk-utils.js
@ibelar ibelar added the BC-break label Sep 2, 2020
@ibelar ibelar changed the title Refactor Js Atk Bundle Refactor Js Atk Bundle eventBus Sep 2, 2020
@ibelar ibelar added RTM and removed RTM labels Sep 2, 2020
@ibelar ibelar marked this pull request as draft September 3, 2020 14:24
@ibelar ibelar marked this pull request as ready for review September 8, 2020 19:16
@ibelar ibelar added the RTM label Sep 8, 2020
@DarkSide666 DarkSide666 self-requested a review September 14, 2020 14:56
DarkSide666
DarkSide666 approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibelar ibelar merged commit 9feb984 into develop Sep 14, 2020
@ibelar ibelar deleted the feature/js-bundle-event branch September 14, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
BC-break RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibelar @DarkSide666