Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch all errors by App handler incl. php notices #1453

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Catch all errors by App handler incl. php notices #1453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa8e18
Catch all errors by App handler incl. php notices
mvorisek Sep 17, 2020
d88c212
improve constant loopkup
mvorisek Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/App.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,6 @@ class App
*/
public $call_exit = true;

/**
* Error types to be in set_error_handler.
*
* @var int
*/
protected $catch_error_types = E_ALL & ~E_NOTICE;

/**
* @var string|null
*/
Expand Down Expand Up @@ -207,7 +200,7 @@ public function __construct($defaults = [])
static function ($severity, $msg, $file, $line) {
throw new \ErrorException($msg, 0, $severity, $file, $line);
},
$this->catch_error_types
\E_ALL
);
}

Expand Down