Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Lookup add condition after model is set #1558

Merged
merged 1 commit into from
Dec 4, 2020
Merged

[fix] Lookup add condition after model is set #1558

merged 1 commit into from
Dec 4, 2020

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Dec 4, 2020

replacement for PR #1556

@ibelar ibelar mentioned this pull request Dec 4, 2020
Closed
@ibelar ibelar added the RTM label Dec 4, 2020
@mvorisek
Copy link
Member

mvorisek commented Dec 4, 2020

I think our code should not lead to these fixes, but ok for now

@DarkSide666 DarkSide666 self-requested a review December 4, 2020 17:39
DarkSide666
DarkSide666 approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarkSide666 DarkSide666 merged commit 16c6efb into develop Dec 4, 2020
@DarkSide666 DarkSide666 deleted the fix/1556-lookup-add-condition branch December 4, 2020 17:39
@mhuser
Copy link
Contributor

mhuser commented Dec 5, 2020

Great, thank you so much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ibelar @mvorisek @mhuser @DarkSide666