Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some phpstan warnings #1580

Merged
merged 7 commits into from
Oct 6, 2021
Merged

Fix some phpstan warnings #1580

merged 7 commits into from
Oct 6, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 26, 2020 •
edited
Loading

finish already merged #1554

@mvorisek mvorisek requested a review from ibelar December 26, 2020 10:11
@mvorisek mvorisek force-pushed the fix_phpstan_all_non_undefined2 branch 2 times, most recently from ceca668 to 7b6e8b5 Compare December 27, 2020 12:07
@mvorisek mvorisek changed the title Fix all non-undefined PHPStan ignores 2/2 Fix all non-undefined PHPStan ignores 2/2 (level 2) Dec 27, 2020
@mvorisek mvorisek force-pushed the fix_phpstan_all_non_undefined2 branch 2 times, most recently from 573c69f to 8891964 Compare December 30, 2020 17:33
@mvorisek mvorisek closed this Mar 3, 2021
@mvorisek mvorisek deleted the fix_phpstan_all_non_undefined2 branch March 3, 2021 10:01
@mvorisek mvorisek restored the fix_phpstan_all_non_undefined2 branch March 3, 2021 10:02
@mvorisek mvorisek reopened this Mar 3, 2021
@mvorisek mvorisek force-pushed the fix_phpstan_all_non_undefined2 branch from 8891964 to c806723 Compare March 4, 2021 12:42
@mvorisek mvorisek force-pushed the fix_phpstan_all_non_undefined2 branch from c806723 to 592fa26 Compare April 10, 2021 11:14
@mvorisek mvorisek force-pushed the fix_phpstan_all_non_undefined2 branch from 592fa26 to 2e7ff46 Compare May 11, 2021 14:01
@mvorisek mvorisek force-pushed the fix_phpstan_all_non_undefined2 branch 5 times, most recently from f64969a to 0696907 Compare October 4, 2021 20:02
@mvorisek mvorisek changed the title Fix all non-undefined PHPStan ignores 2/2 (level 2) Fix some phpstan warnings Oct 4, 2021
@mvorisek mvorisek force-pushed the fix_phpstan_all_non_undefined2 branch from 326d048 to 3ba90b5 Compare October 4, 2021 20:53
@mvorisek mvorisek force-pushed the fix_phpstan_all_non_undefined2 branch from 3ba90b5 to b88521f Compare October 5, 2021 21:38
@mvorisek
Copy link
Member Author

mvorisek commented Oct 6, 2021

@ibelar thanks, please approve and merge

ibelar
ibelar approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibelar ibelar merged commit fe68475 into develop Oct 6, 2021
@ibelar ibelar deleted the fix_phpstan_all_non_undefined2 branch October 6, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibelar ibelar ibelar approved these changes

Assignees

@ibelar ibelar

Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvorisek @ibelar