Improve callbacks url generation

[ibelar]

• move back URL method to View class;
• remove Modal $viewUrl property hack;
• simplify URL generation for callbacks;

[ibelar]

Why did you put back global stickyGet to the callback? V2 Url as discuss above will contains the callback arguments which we want to prevent right? Seem like the test is passing no matter what....not sure why but it need to be fixed.

My manual test shows that when Callback is run; V2 URL will contain the callback argument.

$app->catch_runaway_callbacks = false;

$b1 = Button::addTo($app)->set('trigger callback');

$v1 = \Atk4\Ui\View::addTo($app);
$cb = \Atk4\Ui\Callback::addTo($v1);

$cb->set(function () use ($v1, $cb) {
    $v3 = \Atk4\Ui\View::addTo($v1);
    $v3->set($cb->getUrl());
    \Atk4\Ui\View::addTo($v3)->set($v3->url());
});

$v2 = \Atk4\Ui\View::addTo($v1);
$v2->set('v2 url: ' . $v2->url());

$b1->link($cb->getUrl());

When using include running callback V2 URL was correct.

[mvorisek]

I think we should handle collecting the trigger names differently, eg. collect them when building the URL, eg. traversing up the render tree/parents.

The test passes, please fix and open a new draft PR. I can look at the better impl. then.

[ibelar]

Can you revert to the state it was prior to your changes? I will fix the test then. Envoyé de mon iPhone

…

Le 21 juill. 2021 à 19:07, Michael Voříšek ***@***.***> a écrit :  I think we should handle collecting the trigger names differently, eg. collect them when building the URL, eg. traversing up the render tree/parents. The test passes, please fix and open a new draft PR. I can look at the better impl. then. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[mvorisek]

Can you revert to the state it was prior to your changes? I will fix the test then. Envoyé de mon iPhone
…
Le 21 juill. 2021 à 19:07, Michael Voříšek @.***> a écrit :  I think we should handle collecting the trigger names differently, eg. collect them when building the URL, eg. traversing up the render tree/parents. The test passes, please fix and open a new draft PR. I can look at the better impl. then. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

here you go #1651