Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS lock file and JS CI lint #1648

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Fix JS lock file and JS CI lint #1648

merged 2 commits into from
Jul 12, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Jul 12, 2021 •
edited
Loading

fixes #1524

created by:

  1. using released lodash 4.x

  2. updating lodash from git

npm install "https://github.com/lodash/lodash.git#2da024c3b4"

@mvorisek mvorisek requested a review from ibelar July 12, 2021 16:33
@mvorisek mvorisek force-pushed the remove_manual_wait_from_behat branch from 8e66ccd to 364029d Compare July 12, 2021 16:38
@mvorisek mvorisek added the RTM label Jul 12, 2021
@mvorisek mvorisek changed the title Fix JS lock file and lint Fix JS lock file and JS CI lint Jul 12, 2021
ibelar
ibelar approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibelar ibelar merged commit c193b40 into develop Jul 12, 2021
@ibelar ibelar deleted the remove_manual_wait_from_behat branch July 12, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibelar ibelar ibelar approved these changes

Assignees
No one assigned
Labels
RTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvorisek @ibelar