Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering possibility for float and atk4_money DBAL types #1703

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Add filtering possibility for float and atk4_money DBAL types #1703

merged 3 commits into from
Nov 29, 2021

Conversation

mkrecek234
Copy link
Contributor

Please add these missing filters for table columns

@mvorisek
Copy link
Member

I prefer to register TypeNumber class to handle the float/atk4_money types instead.

@mkrecek234
Copy link
Contributor Author

It auto-references the Filter today towards FilterAtk4_money, so in case this is missing, no filtered grid will work. I would prefer to include by now, so grid supports any field type and is not throwing errors.

@mvorisek mvorisek changed the title Filter for Float and Atk4_money Add filtering possibility for float and atk4_money DBAL types Nov 24, 2021
@mvorisek
Copy link
Member

@mkrecek234 please test

@mkrecek234
Copy link
Contributor Author

@mvorisek Tested and working👍

@mvorisek mvorisek merged commit 5954556 into atk4:develop Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants