Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add late output error test #1719

Merged
merged 17 commits into from
Dec 28, 2021
Merged

Add late output error test #1719

merged 17 commits into from
Dec 28, 2021

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 24, 2021

extracted from #1706 , originally authored by @abbadon1334

I belive php instance state cannot be reverted after some late error tests, eg. the side effects of unamanged headers/output sent can be tested with HTTP tests only.

Also fixes 500 status code when unmanaged output/headers are flushed by an user manually.

@mvorisek mvorisek force-pushed the test_late_output_error branch 5 times, most recently from 3880550 to a09e6f4 Compare December 27, 2021 17:52
@mvorisek mvorisek force-pushed the test_late_output_error branch 2 times, most recently from ca016a5 to 9175df5 Compare December 27, 2021 19:08
@mvorisek mvorisek force-pushed the test_late_output_error branch 2 times, most recently from 83776ec to 415bbb2 Compare December 27, 2021 19:26
@mvorisek mvorisek force-pushed the test_late_output_error branch 2 times, most recently from e8030a8 to e4dd727 Compare December 27, 2021 20:37
@mvorisek mvorisek force-pushed the test_late_output_error branch 3 times, most recently from bfe2ad6 to 3dbd824 Compare December 27, 2021 20:47
@mvorisek mvorisek marked this pull request as ready for review December 27, 2021 21:11
@mvorisek mvorisek merged commit 82a056c into develop Dec 28, 2021
@mvorisek mvorisek deleted the test_late_output_error branch December 28, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant