Add custom decimal separator support for atk4_money type #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for configuring decimal and thousands separators for
atk4_moneytype.by default we use:
.(point) as a decimal point separator as this is more or less international (in EU,,is default, but inUS, it may be interchanged to thousands deparator)* NBSP does not work implicitly in MS Excel, but when copyed from web, NBSP is transformed to regular SP by the most common webbrowsers like Chrome or Firefox
* also MS Excels accept spaces strictly only as a thousands separator (at least 3 num digits must follow), leading/trailing space, space after currency symbol, but not anywhere else (like
1 2.3,1.888 999)