Fix coverage static analysis cache and move util for reuse #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
collect_coverage_for_demos
branch
10 times, most recently
from
e0ce7e9
to
8dedf51
Compare
mvorisek
changed the title
mvorisek
commented
Aug 30, 2022
| comment: false | ||
| coverage: | ||
| status: | ||
| project: | ||
| default: | ||
| target: auto | ||
| threshold: 0.025 | ||
| threshold: 0.015 |
There was a problem hiding this comment.
0.015% equals 1 uncovered line pass, but 2 emit an CI error badge
non-zero is needed to prevent rounding/random errors by Covecov
mvorisek
force-pushed
the
collect_coverage_for_demos
branch
from
8dedf51
to
f084361
Compare
|
this PR can possibly improve also the random Behat failures, but still does not fix all of them, needs deeper investigation why they happen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related upstream performance fixes:
reduces Unit/Behat testing times /w coverage by about 3x
Unit time: before ~6 mins, now ~2 mins
Behat time: before ~4.5 mins, now ~2 mins