Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Modal::{show, hide} methods #1912

Merged
merged 9 commits into from
Oct 22, 2022
Merged

Rename Modal::{show, hide} methods #1912

merged 9 commits into from
Oct 22, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 22, 2022 •
edited
Loading

for consistency, Modal::show() method "does not show" a modal, it "does generate JS to show" it

other JS generating methods are named fine

@mvorisek mvorisek marked this pull request as ready for review October 22, 2022 13:21
@mvorisek mvorisek merged commit 3af54ed into develop Oct 22, 2022
@mvorisek mvorisek deleted the rename_modal_show_method branch October 22, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mvorisek