Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Card with entity action, entity must not reload #1929

Merged
merged 6 commits into from
Nov 3, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Oct 31, 2022

fix #1723

I am still not sure if we ever want to go with entity/model UA.

But (re)load should really be not done if a loaded entity is passed.

@mvorisek mvorisek marked this pull request as ready for review October 31, 2022 13:20
@mvorisek mvorisek force-pushed the fix_1723_modal_open_with_exception branch from 181176c to f95237c Compare November 3, 2022 00:11
@mvorisek mvorisek force-pushed the fix_1723_modal_open_with_exception branch from 4741f39 to de460d5 Compare November 3, 2022 16:37
@mvorisek mvorisek force-pushed the fix_1723_modal_open_with_exception branch from de460d5 to db60f46 Compare November 3, 2022 16:42
@mvorisek mvorisek force-pushed the fix_1723_modal_open_with_exception branch from db60f46 to b952ca1 Compare November 3, 2022 16:59
@mvorisek mvorisek marked this pull request as draft November 3, 2022 20:33
@mvorisek mvorisek marked this pull request as ready for review November 3, 2022 21:01
@mvorisek mvorisek merged commit 9d32361 into develop Nov 3, 2022
@mvorisek mvorisek deleted the fix_1723_modal_open_with_exception branch November 3, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card demo is broken
1 participant