Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing JS preventDefault/stopPropagation #1942

Merged
merged 5 commits into from
Dec 1, 2022
Merged

Fix missing JS preventDefault/stopPropagation #1942

merged 5 commits into from
Dec 1, 2022

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Dec 1, 2022 •
edited

marking as BC-break as newly View::js() stops JS event propagation by default the same as View::on() (since ages already) does

@mvorisek mvorisek changed the title Fix no JS preventDefault/stopPropagation Fix missing JS preventDefault/stopPropagation Dec 1, 2022
@mvorisek mvorisek merged commit 775782c into develop Dec 1, 2022
@mvorisek mvorisek deleted the unify_js_on branch December 1, 2022 23:34
@mvorisek mvorisek mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC-break
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mvorisek