No hardcoded template attributes #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
no_hardcoded_template_attributes
branch
13 times, most recently
from
4426736
to
16c02a2
Compare
mvorisek
force-pushed
the
no_hardcoded_template_attributes
branch
4 times, most recently
from
3f7b214
to
2ae3b92
Compare
(,? |(?<=\())id="\{\$_id\}"(?=[^()<>]*(?<!\w)attributes(?!\w))
(,? |(?<=\())style="\{\$style\}"(?=[^()<>]*(?<!\w)attributes(?!\w))
(,? |(?<=\())class="\{_ui\}ui\{/\} +(\{\$class\}|\{class\}\{/\}) +(\{\$_class\}|\{_class\}\{/\})"(?=[^()<>]*(?<!\w)attributes(?!\w))
mvorisek
force-pushed
the
no_hardcoded_template_attributes
branch
2 times, most recently
from
e69cdda
to
da15da1
Compare
mvorisek
force-pushed
the
no_hardcoded_template_attributes
branch
4 times, most recently
from
c346710
to
10be88b
Compare
This reverts commit 4fa621212d792a38153e72c2f72aee3da7d43839.
This reverts commit 96246000726f9b6abc88dc5a61962a433c93612e.
This reverts commit 0a53889.
mvorisek
force-pushed
the
no_hardcoded_template_attributes
branch
from
dd9b970
to
237ed5c
Compare
mvorisek
requested review from
georgehristov,
abbadon1334,
DarkSide666,
ibelar,
mkrecek234,
PhilippGrashoff and
romaninsh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1028
needed for #101
time to create/clone basic (
template/element.html) template and to render it has been reduced by ~25% (related with #1976)see
template/element.htmlchanges to understand how to migrate your templatesif you do not use custom templates, no action should be needed
in
Viewclass a few hacks are needed as{$attributes}tag cannot be put into all templates currently, I belive the hacks are ok otherwise a massiveHtmlTemplaterewrite would be needed to support these casesregex to find templates /wo
attributestag:(?<!\s|\S)^((?!attributes)(\s|\S))*$(?!\s|\S)