Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple JS statements must be passed in JsBlock #1997

Merged
merged 20 commits into from
Feb 21, 2023
Merged

Multiple JS statements must be passed in JsBlock #1997

merged 20 commits into from
Feb 21, 2023

Conversation

mvorisek
Copy link
Member

@mvorisek mvorisek commented Feb 16, 2023

Previously mixed JsExpression and array types were used making correct OOP design impossible.

This was also dangerous as array<JsExpressionable> is encodeable to JSON with a completely different result.

@mvorisek mvorisek force-pushed the jsblock branch 4 times, most recently from 10f7a0e to 6ebeeab Compare February 19, 2023 12:42
@mvorisek mvorisek force-pushed the jsblock branch 3 times, most recently from bb56ace to 69abc1a Compare February 21, 2023 13:19
@mvorisek mvorisek marked this pull request as ready for review February 21, 2023 13:41
@mvorisek mvorisek merged commit 3c592b8 into develop Feb 21, 2023
@mvorisek mvorisek deleted the jsblock branch February 21, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant