Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace $_GET/$_POST/$_FILES with App::getRequestXxx() #2101

Merged
merged 103 commits into from
Sep 30, 2023
Merged

Replace $_GET/$_POST/$_FILES with App::getRequestXxx() #2101

merged 103 commits into from
Sep 30, 2023

Conversation

abbadon1334
Copy link
Collaborator

@abbadon1334 abbadon1334 commented Sep 5, 2023 •
edited by mvorisek
Loading

fix #2009

@abbadon1334
Fix PrettyUrl legitimate path
7fdbbe7
@abbadon1334
Add Unit tests for App::url
ba90e32
@abbadon1334
add default excepted page and extension
f2dd8f3
@abbadon1334
fix 7.4 array merge with keys / spread operator
6713d61
@abbadon1334
Add more test cases for App:url
04720c5
@abbadon1334
Reorganize code
80b8fca
@abbadon1334
Improve converage
27d9cb4
@abbadon1334
Improve App::url tests
67f0594
@abbadon1334
Skip $useRequestUrl=true due to REQUEST_URI
b2810b8
@abbadon1334
Change REQUEST_URI to Psr7 methods
3997714
@abbadon1334
Allow $useRequestUrl=true
4348ff1
@abbadon1334
clean up
e4c3428
@abbadon1334
Improve error message
7895ec9
@abbadon1334
CS Fix
f1fefac
@abbadon1334
Merge branch 'develop' into add_tests_app_url
308cc87
@abbadon1334
Add App::$urlBuildingPage to customize url building page
23a5a6b
@abbadon1334
Comment out App::url failing tests
f3f099f
@abbadon1334
Merge branch 'develop' into fix_pretty_url_legitimate_path
3c36038
@abbadon1334
Avoid change of global var $_SERVER
534cff4
@abbadon1334
Fix missing request in App for Unit tests
a01c3bb
@abbadon1334
Comment out not working tests
62f370b
@abbadon1334
removed getRequestUrl
8b3561e
@abbadon1334
Add failing tests
b6ae878
@abbadon1334
Add methods App::issetRequestXxx App::getRequestXxx
c7840f1
@abbadon1334
Replaced all $_FILES
f7e819a
@abbadon1334
Replace $_GET App::getRequestGetParam
279f796
@abbadon1334
Replace $_GET App::getRequestGetParam
c2e175c
@abbadon1334
Replace $_GET App::getRequestGetParam
e4fb8ab
@abbadon1334
Add App::tryGetRequestGetParam not raise exceptiona nd return null if…
029580c 
… not present
@abbadon1334
Replace $_GET App::has/get/tryGet/RequestGetParam
f7bf3fb
@mvorisek mvorisek force-pushed the use_request_not_globals branch 3 times, most recently from 53f400c to e4a135f Compare September 26, 2023 09:58
@atk4 atk4 deleted a comment from abbadon1334 Sep 26, 2023
@mvorisek mvorisek force-pushed the use_request_not_globals branch 2 times, most recently from 6940806 to 6143477 Compare September 26, 2023 10:32
mvorisek
mvorisek reviewed Sep 26, 2023
View reviewed changes
src/App.php Outdated Show resolved Hide resolved
mvorisek
mvorisek reviewed Sep 26, 2023
View reviewed changes
demos/init-app.php Outdated Show resolved Hide resolved
@mvorisek mvorisek marked this pull request as ready for review September 30, 2023 11:13
@mvorisek mvorisek merged commit 8dd4f7b into develop Sep 30, 2023
57 checks passed
@mvorisek mvorisek deleted the use_request_not_globals branch September 30, 2023 11:34
@mvorisek
Copy link
Member

Thank you @abbadon1334, quality PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek left review comments

Assignees
No one assigned
Labels
MAJOR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct access of $_GET/$_POST/$_FILES must be replaced with App::getRequestXxx()
2 participants
@abbadon1334 @mvorisek