Use View::$entity property for entity access #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
changed the title
mvorisek
force-pushed
the
form_entity_property
branch
from
dfab4e3
to
7f9be35
Compare
mvorisek
force-pushed
the
form_entity_property
branch
from
aa80922
to
41d5803
Compare
mvorisek
force-pushed
the
form_entity_property
branch
from
6027f62
to
1a6f47f
Compare
mvorisek
force-pushed
the
form_entity_property
branch
from
b8b507f
to
701161b
Compare
DarkSide666
reviewed
Mar 27, 2024
DarkSide666
reviewed
Mar 27, 2024
DarkSide666
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Minor comments, but didn't review all toughly.
I guess i understand the purpose, but it will make life a bit more complicated for programmer to remember that form views have entity, but grid views have model.
I do not have a lot of up to date code, but time ago using $form->model was quite a common case. Especially in form submit callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 99% cases the impact is on
Form::$modelproperty usage. Seachform->modelin your codebase and replace it withform->entity.The motivation is to simplify model/entity orientation for the developer. When Model is guaranteed to be entity only, is should never be named model.