New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/dynamic-popup #427
Conversation
Simply add a popup View compatible with semantic-ui
Codecov Report
@@ Coverage Diff @@
## develop #427 +/- ##
=============================================
- Coverage 69.43% 67.91% -1.52%
- Complexity 1384 1420 +36
=============================================
Files 75 76 +1
Lines 3278 3354 +76
=============================================
+ Hits 2276 2278 +2
- Misses 1002 1076 +74
Continue to review full report at Codecov.
|
so far i like the implementation. Quite clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like this. Still needs docs though.
demos/popup.php
Outdated
->setHoverable() | ||
->setOption('delay', ['show' => 100, 'hide' => 400]); | ||
|
||
$v = $pop->add('View', ['ui'=>'fluid']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think we could have option to either add like this or set a callback for ajax? similar to how we have it in Modal ?
Semantic-ui Popup seems to have problem when more that one popup are located within button or menu item that activate them. Need to move popup view to same level as layout in dom in order to have multiple popup working correctly.
Popup View
Simple popup view compatible with semantic-ui.
Popup content can be add statically or dynamically via a callback url.
Statically
Example, setting a button to display a pop window on click.
Dynamically
Example, implementing a cart menu item that display a dynamic popup.
Demo
You can see a running demo in /demos/popup.php
Note
atkjs-ui.js need to be rebuild.