Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/#522 Ajax error display #529

Merged
merged 4 commits into from Jul 24, 2018
Merged

fix/#522 Ajax error display #529

merged 4 commits into from Jul 24, 2018

Conversation

ibelar
Copy link
Contributor

@ibelar ibelar commented Jul 23, 2018

This will catch up callback request when exception occur and properly format server response in order to properly handle exception.

fixes #522

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #529 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #529      +/-   ##
=============================================
- Coverage      66.81%   66.77%   -0.04%     
- Complexity      1600     1601       +1     
=============================================
  Files             90       90              
  Lines           3842     3844       +2     
=============================================
  Hits            2567     2567              
- Misses          1275     1277       +2
Impacted Files Coverage Δ Complexity Δ
src/App.php 73.75% <0%> (-0.62%) 105 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44dbab7...f0ce747. Read the comment docs.

@romaninsh romaninsh merged commit 72e2f99 into develop Jul 24, 2018
@romaninsh romaninsh deleted the fix/#522 branch July 24, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If AJAX request fails - provide user-friendly way to see error
2 participants