Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support for serialized fields #548

Merged
merged 6 commits into from
Aug 27, 2018

Conversation

romaninsh
Copy link
Member

Field can have "serialize" property set:

$this->addField('tags', ['serialize'=>'json']);

This field will now be properly presented in the UI according to the type.

$new_value = $this->serializeLoadField($f, $value);
} catch (\Exception $e) {
throw new Exception([
'Value must be '.$f->serialize,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point to have $f->serialize parameter twice in exception?
And will it also show underlying exception message from agile data?

@codecov
Copy link

codecov bot commented Aug 27, 2018

Codecov Report

Merging #548 into develop will decrease coverage by 1.03%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #548      +/-   ##
============================================
- Coverage      66.73%   65.7%   -1.04%     
- Complexity      1627    1631       +4     
============================================
  Files             91      91              
  Lines           3890    3901      +11     
============================================
- Hits            2596    2563      -33     
- Misses          1294    1338      +44
Impacted Files Coverage Δ Complexity Δ
src/Persistence/UI.php 40.74% <9.09%> (-4.98%) 43 <0> (+4)
src/jsCallback.php 27.27% <0%> (-39.4%) 32% <0%> (ø)
src/App.php 69.91% <0%> (-2.04%) 109% <0%> (ø)
src/View.php 80.81% <0%> (-0.95%) 136% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b4e48...924416a. Read the comment docs.

@romaninsh romaninsh merged commit 5694267 into develop Aug 27, 2018
@romaninsh romaninsh deleted the feature/support-for-serialized-fields branch August 27, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants