Don't apply sorting in case sortable=false. #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsPaginator also exclusively calls applySort(), so applySort() should take care of that itself.
ibelar
approved these changes
Jan 17, 2019
Codecov Report
@@ Coverage Diff @@
## develop #635 +/- ##
=============================================
- Coverage 69.2% 69.17% -0.03%
+ Complexity 1853 1852 -1
=============================================
Files 100 100
Lines 4374 4373 -1
=============================================
- Hits 3027 3025 -2
- Misses 1347 1348 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #635 +/- ##
=============================================
- Coverage 69.2% 69.17% -0.03%
+ Complexity 1853 1852 -1
=============================================
Files 100 100
Lines 4374 4373 -1
=============================================
- Hits 3027 3025 -2
- Misses 1347 1348 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't apply sorting in case sortable=false.
jsPaginator also exclusively calls applySort(), so applySort() should take care of that itself.