Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/implement grid layout #662

Merged
merged 4 commits into from Feb 25, 2019
Merged

Conversation

DarkSide666
Copy link
Member

implementation + small demo

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initial draft...

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #662 into develop will increase coverage by 2.94%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #662      +/-   ##
=============================================
+ Coverage      69.82%   72.76%   +2.94%     
- Complexity      1864     1868       +4     
=============================================
  Files            101      102       +1     
  Lines           4394     4417      +23     
=============================================
+ Hits            3068     3214     +146     
+ Misses          1326     1203     -123
Impacted Files Coverage Δ Complexity Δ
src/GridLayout.php 100% <100%> (ø) 4 <4> (?)
src/Label.php 57.14% <0%> (-28.58%) 6% <0%> (ø)
src/ItemsPerPageSelector.php 65.51% <0%> (-3.45%) 11% <0%> (ø)
src/Table.php 86.23% <0%> (+1.21%) 111% <0%> (ø) ⬇️
src/View.php 82.26% <0%> (+1.22%) 142% <0%> (ø) ⬇️
src/FormField/DropDown.php 90.9% <0%> (+1.81%) 30% <0%> (ø) ⬇️
src/FormLayout/_Abstract.php 86.36% <0%> (+3.03%) 32% <0%> (ø) ⬇️
src/Lister.php 72.88% <0%> (+3.38%) 23% <0%> (ø) ⬇️
src/FormLayout/Generic.php 100% <0%> (+8.86%) 34% <0%> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79337b4...2e83a05. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #662 into develop will decrease coverage by 0.43%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #662      +/-   ##
=============================================
- Coverage      69.82%   69.39%   -0.44%     
- Complexity      1864     1868       +4     
=============================================
  Files            101      102       +1     
  Lines           4394     4417      +23     
=============================================
- Hits            3068     3065       -3     
- Misses          1326     1352      +26
Impacted Files Coverage Δ Complexity Δ
src/GridLayout.php 0% <0%> (ø) 4 <4> (?)
src/TableColumn/Status.php 73.52% <0%> (-8.83%) 12% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79337b4...3e00d73. Read the comment docs.

@DarkSide666 DarkSide666 merged commit 5cc759a into develop Feb 25, 2019
@DarkSide666 DarkSide666 deleted the feature/implement-grid-layout branch February 25, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants