Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container for action buttons #669

Merged
merged 2 commits into from Mar 4, 2019
Merged

Conversation

DarkSide666
Copy link
Member

@DarkSide666 DarkSide666 commented Mar 2, 2019

See description in #668. fix #668.

Before:

before
before2

After:

after
after2

@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #669 into develop will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #669      +/-   ##
=============================================
- Coverage      72.75%   72.74%   -0.02%     
- Complexity      1868     1869       +1     
=============================================
  Files            102      102              
  Lines           4416     4418       +2     
=============================================
+ Hits            3213     3214       +1     
- Misses          1203     1204       +1
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Actions.php 90.9% <75%> (-2.64%) 12 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4296a25...2a5b296. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #669 into develop will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #669      +/-   ##
=============================================
- Coverage      72.75%   72.74%   -0.02%     
- Complexity      1868     1869       +1     
=============================================
  Files            102      102              
  Lines           4416     4418       +2     
=============================================
+ Hits            3213     3214       +1     
- Misses          1203     1204       +1
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Actions.php 90.9% <75%> (-2.64%) 12 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4296a25...2a5b296. Read the comment docs.

Copy link
Contributor

@ibelar ibelar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good also because it remove space between buttons so making column width smaller.

@DarkSide666 DarkSide666 merged commit 3208b13 into develop Mar 4, 2019
@DarkSide666 DarkSide666 deleted the feature/actions-container branch March 4, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad icon and text button vertical alignment
3 participants