-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some new TableColumns #726
Conversation
Awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good and very clean, but need demos and documentaiton.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this PR - useful and clean, but need documentation and even more important - some demo page. Also please check out my other review comments.
b961b95
to
4b98313
Compare
Codecov Report
@@ Coverage Diff @@
## develop #726 +/- ##
=============================================
- Coverage 68.49% 67.09% -1.41%
- Complexity 2062 2107 +45
=============================================
Files 106 110 +4
Lines 4857 4984 +127
=============================================
+ Hits 3327 3344 +17
- Misses 1530 1640 +110
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## develop #726 +/- ##
=============================================
- Coverage 68.49% 67.09% -1.41%
- Complexity 2062 2107 +45
=============================================
Files 106 110 +4
Lines 4857 4984 +127
=============================================
+ Hits 3327 3344 +17
- Misses 1530 1640 +110
Continue to review full report at Codecov.
|
Merged through #743 , closing this. |
Some TableColumn classes
in the DocBlock of every class there is instructions for the usage, try to use it and see if it is useful.
After that we can create demos and docs for it.
P.S. in the PR there is even the #702 issue, and i don't know how to remove it :(