Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some new TableColumns #726

Closed
wants to merge 20 commits into from

Conversation

abbadon1334
Copy link
Collaborator

@abbadon1334 abbadon1334 commented Jun 2, 2019

Some TableColumn classes

  • TableColumn/ExternalLink : open an external link or an url with download attribute
  • TableColumn/KeyValue : to show values from a enum field
  • TableColumn/NoValue : show a defined value in place of an empty string
  • TableColumn/Labels : convert a comma separated list of values to labels
  • TableColumn/Tooltip : that add an iconTooltip (TT content from another field)
  • TableColumn/ColorRating : generate a background color gradient based on the value

in the DocBlock of every class there is instructions for the usage, try to use it and see if it is useful.

After that we can create demos and docs for it.

P.S. in the PR there is even the #702 issue, and i don't know how to remove it :(

  • Documentation
  • Demos

@acicovic
Copy link
Collaborator

acicovic commented Jun 3, 2019

Awesome!

Copy link
Member

@romaninsh romaninsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and very clean, but need demos and documentaiton.

@romaninsh romaninsh added the Documentation 📚 Undocumented features label Jun 3, 2019
Copy link
Member

@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this PR - useful and clean, but need documentation and even more important - some demo page. Also please check out my other review comments.

src/TableColumn/ExternalLink.php Outdated Show resolved Hide resolved
src/TableColumn/KeyValue.php Outdated Show resolved Hide resolved
src/TableColumn/Labels.php Show resolved Hide resolved
src/TableColumn/Tooltip.php Outdated Show resolved Hide resolved
src/TableColumn/Tooltip.php Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #726 into develop will decrease coverage by 1.4%.
The diff coverage is 34.3%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #726      +/-   ##
=============================================
- Coverage      68.49%   67.09%   -1.41%     
- Complexity      2062     2107      +45     
=============================================
  Files            106      110       +4     
  Lines           4857     4984     +127     
=============================================
+ Hits            3327     3344      +17     
- Misses          1530     1640     +110
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Labels.php 0% <0%> (ø) 3 <3> (?)
src/TableColumn/ColorRating.php 0% <0%> (ø) 23 <23> (?)
src/App.php 71.59% <60%> (-0.55%) 120 <0> (ø)
src/TableColumn/Tooltip.php 77.77% <77.77%> (ø) 10 <10> (?)
src/TableColumn/NoValue.php 80% <80%> (ø) 3 <3> (?)
src/TableColumn/Generic.php 82.56% <83.33%> (-0.13%) 38 <0> (+1)
src/TableColumn/Link.php 90.69% <91.66%> (+0.07%) 25 <0> (+5) ⬆️
src/jsSearch.php 10% <0%> (-75%) 5% <0%> (ø)
src/ItemsPerPageSelector.php 34.48% <0%> (-31.04%) 11% <0%> (ø)
src/Paginator.php 90% <0%> (-1.43%) 33% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76ac79...4b98313. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #726 into develop will decrease coverage by 1.4%.
The diff coverage is 34.3%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #726      +/-   ##
=============================================
- Coverage      68.49%   67.09%   -1.41%     
- Complexity      2062     2107      +45     
=============================================
  Files            106      110       +4     
  Lines           4857     4984     +127     
=============================================
+ Hits            3327     3344      +17     
- Misses          1530     1640     +110
Impacted Files Coverage Δ Complexity Δ
src/TableColumn/Labels.php 0% <0%> (ø) 3 <3> (?)
src/TableColumn/ColorRating.php 0% <0%> (ø) 23 <23> (?)
src/App.php 71.59% <60%> (-0.55%) 120 <0> (ø)
src/TableColumn/Tooltip.php 77.77% <77.77%> (ø) 10 <10> (?)
src/TableColumn/NoValue.php 80% <80%> (ø) 3 <3> (?)
src/TableColumn/Generic.php 82.56% <83.33%> (-0.13%) 38 <0> (+1)
src/TableColumn/Link.php 90.69% <91.66%> (+0.07%) 25 <0> (+5) ⬆️
src/jsSearch.php 10% <0%> (-75%) 5% <0%> (ø)
src/ItemsPerPageSelector.php 34.48% <0%> (-31.04%) 11% <0%> (ø)
src/Paginator.php 90% <0%> (-1.43%) 33% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d76ac79...11364a9. Read the comment docs.

@romaninsh
Copy link
Member

Merged through #743 , closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📚 Undocumented features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants