Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Validator, create ValidatorRule class #20

Merged
merged 49 commits into from
Apr 19, 2024
Merged

Refactor Validator, create ValidatorRule class #20

merged 49 commits into from
Apr 19, 2024

Commits on Apr 14, 2024

  1. introduce ValidatorRule and refactor code and add/fix tests

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    579a61a View commit details
    Browse the repository at this point in the history

  2. add phptype ValidatorCallback

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    ac38294 View commit details
    Browse the repository at this point in the history

  3. set phpstan-type for valitron rules

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    142e503 View commit details
    Browse the repository at this point in the history

  4. address review comments

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    94fd394 View commit details
    Browse the repository at this point in the history

  5. improve doc

    @mvorisek
    mvorisek committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    627f26c View commit details
    Browse the repository at this point in the history

  6. sort validators, rename method to addRule

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    48ae9aa View commit details
    Browse the repository at this point in the history

  7. add ValidatorCondition typehint and fix it

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    96a3ead View commit details
    Browse the repository at this point in the history

  8. better user Model compare method

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    e57308b View commit details
    Browse the repository at this point in the history

  9. add tests for complex data type (date)

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    5135e37 View commit details
    Browse the repository at this point in the history

  10. test

    @DarkSide666
    DarkSide666 committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    09cea81 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. change test to show how it fails for empty DateTime

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    582c6b9 View commit details
    Browse the repository at this point in the history

  2. show the problem

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5218905 View commit details
    Browse the repository at this point in the history

  3. extend Valitron class and fix bugs there

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2126a95 View commit details
    Browse the repository at this point in the history

  4. proper validation

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    4846bfc View commit details
    Browse the repository at this point in the history

  5. cs fix

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b84cc8d View commit details
    Browse the repository at this point in the history

  6. add Override attribute

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7db8c32 View commit details
    Browse the repository at this point in the history

  7. improve tests for coverage and fix dateFormat rule

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8cea4c3 View commit details
    Browse the repository at this point in the history

  8. better test for dateFormat

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    c4f38cb View commit details
    Browse the repository at this point in the history

  9. add test to improve coverage

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f04f22d View commit details
    Browse the repository at this point in the history

  10. ouch

    @DarkSide666
    DarkSide666 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f155225 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Update src/Validator.php 

    Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
    @DarkSide666 @mvorisek
    DarkSide666 and mvorisek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    68ce5fc View commit details
    Browse the repository at this point in the history

  2. Update src/Validator.php 

    Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
    @DarkSide666 @mvorisek
    DarkSide666 and mvorisek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    46a028f View commit details
    Browse the repository at this point in the history

  3. Update src/ValidatorRule.php 

    Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
    @DarkSide666 @mvorisek
    DarkSide666 and mvorisek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    73c3485 View commit details
    Browse the repository at this point in the history

  4. Update src/ValidatorRule.php 

    Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
    @DarkSide666 @mvorisek
    DarkSide666 and mvorisek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    1cac5b9 View commit details
    Browse the repository at this point in the history

  5. Update src/ValidatorRule.php 

    Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
    @DarkSide666 @mvorisek
    DarkSide666 and mvorisek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    49594f3 View commit details
    Browse the repository at this point in the history

  6. Update tests/BasicTest.php 

    Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
    @DarkSide666 @mvorisek
    DarkSide666 and mvorisek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    365d616 View commit details
    Browse the repository at this point in the history

  7. Update src/ValitronValidator.php 

    Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
    @DarkSide666 @mvorisek
    DarkSide666 and mvorisek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8585e19 View commit details
    Browse the repository at this point in the history

  8. Update src/ValitronValidator.php 

    Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz>
    @DarkSide666 @mvorisek
    DarkSide666 and mvorisek committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ce6c3fa View commit details
    Browse the repository at this point in the history

  9. address review

    @DarkSide666
    DarkSide666 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fc779f5 View commit details
    Browse the repository at this point in the history

  10. start adding tests for fixed valitron validator

    @DarkSide666
    DarkSide666 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    fbb007f View commit details
    Browse the repository at this point in the history

  11. tests

    @DarkSide666
    DarkSide666 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    33dd6ad View commit details
    Browse the repository at this point in the history

  12. test

    @DarkSide666
    DarkSide666 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    ee3ef0a View commit details
    Browse the repository at this point in the history

  13. simplify tests

    @DarkSide666
    DarkSide666 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    d4eadd7 View commit details
    Browse the repository at this point in the history

  14. cs fixes

    @DarkSide666
    DarkSide666 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f592bb3 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. test

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    64b609c View commit details
    Browse the repository at this point in the history

  2. test

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2ff9e0e View commit details
    Browse the repository at this point in the history

  3. test

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    65318ba View commit details
    Browse the repository at this point in the history

  4. catch warnings

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    624f63d View commit details
    Browse the repository at this point in the history

  5. test

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ed288c6 View commit details
    Browse the repository at this point in the history

  6. test

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d559369 View commit details
    Browse the repository at this point in the history

  7. test

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    ddc468e View commit details
    Browse the repository at this point in the history

  8. remove comments

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    d51a941 View commit details
    Browse the repository at this point in the history

  9. * reorder tests to put expected exceptions last 

    * improve tests coverage
    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2573e64 View commit details
    Browse the repository at this point in the history

  10. we do not create coverage report with PHP 7.4

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    cfd2a66 View commit details
    Browse the repository at this point in the history

  11. cs fix

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    2fbcf7a View commit details
    Browse the repository at this point in the history

  12. test

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    85e88c2 View commit details
    Browse the repository at this point in the history

  13. cs fixes

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    7733fa2 View commit details
    Browse the repository at this point in the history

  14. check for precise message

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    9e06c8c View commit details
    Browse the repository at this point in the history

  15. variable naming

    @DarkSide666
    DarkSide666 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    35d4082 View commit details
    Browse the repository at this point in the history