Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow api's for schedule queries #280

Merged
merged 19 commits into from
May 25, 2024
Merged

workflow api's for schedule queries #280

merged 19 commits into from
May 25, 2024

Conversation

nishantmunjal7
Copy link
Collaborator

@nishantmunjal7 nishantmunjal7 commented Mar 27, 2024 •
edited

  1. Add's two new endpoints from heracles to fetch schedule queries cron between a duration and missed schedule queries crons between a duration
  2. Opens up a new function that can fetch details about schedule queries cron using saved query id
  3. Re-triggers a workflow for schedule query, this is different from re-running a workflow. Re-running a workflow gets run using the user who is triggering it, but in case of schedule query, re-run has to happen from the owner of the workflow for queries to work.
  4. Adds an new endpoint for updating the workflow owner, call to heracles

More info:

@Aryamanz29 Aryamanz29 self-requested a review May 7, 2024 12:25
@Aryamanz29
Copy link
Member

Aryamanz29 commented May 7, 2024 •
edited

Hi @nishantmunjal7, thanks for your contribution! 🥳 🎉

I've pushed the refactored changes to this PR, Could you please review these newly added methods manually again on the latest changes 🙏 and let us know if something needs to be updated 😄

Currently, this feature is not enabled on our dev tenant (https://devx8.atlan.com), but we'll be adding integration tests for this feature soon. 💯

@Aryamanz29 Aryamanz29 self-assigned this May 7, 2024
@Aryamanz29 Aryamanz29 added the feature New feature or request label May 7, 2024
@Aryamanz29
Refactored scheduled query methods in WorkflowClient
cd2fa1b 
- Enhanced unit tests.
- Code refactored for improved maintainability.
- Method names shortened and docstrings added for clarity.
Aryamanz29
Aryamanz29 approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@Aryamanz29 Aryamanz29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved conflicts with the main branch. Everything looks good as of now, and this feature will be included in the upcoming release 🎉

@Aryamanz29 Aryamanz29 merged commit 3b66bc7 into main May 25, 2024
31 checks passed
@Aryamanz29 Aryamanz29 deleted the workflows-new-api branch May 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aryamanz29 Aryamanz29 Aryamanz29 approved these changes

Assignees

@Aryamanz29 Aryamanz29

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nishantmunjal7 @Aryamanz29