Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DVX-390: Overloaded creator methods to explicitly handle ancestral qualifiedName and name #343

Merged
merged 13 commits into from
Jun 5, 2024
Merged

DVX-390: Overloaded creator methods to explicitly handle ancestral qualifiedName and name #343

merged 13 commits into from
Jun 5, 2024

Conversation

Aryamanz29
Copy link
Member

@Aryamanz29 Aryamanz29 commented May 31, 2024 •
edited
Loading

  • Added overloaded creator() methods to explicitly manage ancestral qualifiedName and name.
  • Ensured backward compatibility by maintaining existing method signatures.

TODO

  • Add overloaded methods to other assets.
  • Update/Add unit and integration tests.

@Aryamanz29 Aryamanz29 self-assigned this May 31, 2024
@Aryamanz29 Aryamanz29 added the feature New feature or request label May 31, 2024
@Aryamanz29 Aryamanz29 added the WIP Work in progress label Jun 3, 2024
@Aryamanz29 Aryamanz29 marked this pull request as ready for review June 4, 2024 11:00
@ErnestoLoma ErnestoLoma self-requested a review June 4, 2024 11:01
@Aryamanz29
Copy link
Member Author

Java SDK implementation: atlanhq/atlan-java#642

@Aryamanz29 Aryamanz29 removed the WIP Work in progress label Jun 4, 2024
@Aryamanz29 Aryamanz29 requested review from ErnestoLoma and removed request for ErnestoLoma June 5, 2024 09:29
ErnestoLoma
ErnestoLoma requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@ErnestoLoma ErnestoLoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the most common/simplest overridden method should appear first since that determines how it appears in the IDE.
I don't think we should make any changes to the create method since it is deprecated.

pyatlan/generator/templates/methods/asset/a_d_l_s_container.jinja2 Outdated Show resolved Hide resolved
pyatlan/model/assets/a_d_l_s_object.py Outdated Show resolved Hide resolved
pyatlan/model/assets/airflow_task.py Outdated Show resolved Hide resolved
pyatlan/model/assets/column.py Outdated Show resolved Hide resolved
pyatlan/model/assets/column.py Show resolved Hide resolved
pyatlan/model/assets/g_c_s_object.py Show resolved Hide resolved
pyatlan/model/assets/g_c_s_object.py Show resolved Hide resolved
@ErnestoLoma ErnestoLoma self-requested a review June 5, 2024 11:18
@Aryamanz29 Aryamanz29 merged commit ca31db6 into main Jun 5, 2024
33 checks passed
@Aryamanz29 Aryamanz29 deleted the DVX-390 branch June 5, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErnestoLoma ErnestoLoma ErnestoLoma approved these changes

Assignees

@Aryamanz29 Aryamanz29

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Aryamanz29 @ErnestoLoma