Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] DG-996: Support moving Domain/Products across Domains #2927

Merged
merged 57 commits into from
May 7, 2024
Merged

[master] DG-996: Support moving Domain/Products across Domains #2927

merged 57 commits into from
May 7, 2024

Conversation

PRATHAM2002-DS
Copy link

@PRATHAM2002-DS PRATHAM2002-DS commented Apr 10, 2024 •
edited by nikhilbonte21
Loading

Move Domains and Products.

  • We create Domains followed by sub-domains & Products inside a domain. We need to support moving of the sub-domains & Products across the Domains (similar to moving of Categories/Terms acros Glossaries)

This feature will enable users to move the sub-domains from one domain to another and also Split a domain.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

[Fix #1 ](https://atlanhq.atlassian.net/browse/DG-996)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@checkaayush checkaayush deleted the dg-996-move-domain branch April 23, 2024 10:07
@PRATHAM2002-DS PRATHAM2002-DS restored the dg-996-move-domain branch April 24, 2024 07:14
nikhilbonte21
nikhilbonte21 requested changes May 6, 2024
View reviewed changes
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java Outdated Show resolved Hide resolved
...src/main/java/org/apache/atlas/repository/store/graph/v2/preprocessor/PreProcessorUtils.java Outdated Show resolved Hide resolved
common/src/main/java/org/apache/atlas/repository/Constants.java Show resolved Hide resolved
common/src/main/java/org/apache/atlas/repository/Constants.java Outdated Show resolved Hide resolved
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/AbstractDomainPreProcessor.java Outdated Show resolved Hide resolved
...rg/apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataProductPreProcessor.java Outdated Show resolved Hide resolved
@nikhilbonte21 nikhilbonte21 force-pushed the dg-996-move-domain branch 3 times, most recently from 0136bc9 to de1c3b3 Compare May 6, 2024 14:13
@nikhilbonte21 nikhilbonte21 changed the title [master]:- Dg 996 Move Domain [master] DG-996: Support moving Domain/Products across Domains May 6, 2024
@nikhilbonte21 nikhilbonte21 merged commit f260666 into master May 7, 2024
4 checks passed
@sumandas0 sumandas0 deleted the dg-996-move-domain branch May 7, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@checkaayush checkaayush checkaayush approved these changes

@sumandas0 sumandas0 sumandas0 approved these changes

@nikhilbonte21 nikhilbonte21 nikhilbonte21 approved these changes

Assignees
No one assigned
Labels
READY FOR REVIEW
Projects
None yet
Milestone
No milestone
4 participants
@PRATHAM2002-DS @checkaayush @sumandas0 @nikhilbonte21