Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add feature flag storage based on Redis and maintenance mode based on feature flag #2998

Merged
merged 7 commits into from
May 7, 2024

Conversation

sumandas0
Copy link

Feature flag storage powered by Redis

Add an Redis based feature flag to apply feature flag without restarting the pod, this will will help us in multiple occasion where we need do this, like to block write functionality but without any delay of the pod restart.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@sumandas0 sumandas0 self-assigned this May 3, 2024
@sumandas0
Copy link
Author

sumandas0 commented May 3, 2024

Add feature flag disable_writes = true

curl --location --request POST 'http://localhost:21000/api/atlas/v2/admin/featureFlag?key=disable_writes&value=true' 

Delete feature flag, disable_writes

curl --location --request DELETE 'http://localhost:21000/api/atlas/v2/admin/featureFlag/disable_writes' 

@sumandas0 sumandas0 merged commit 4356129 into master May 7, 2024
4 checks passed
@sumandas0 sumandas0 deleted the maintenance-mode-redis branch May 7, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants