Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG-1357 Custom metadata access for mesh assets #3078

Merged
merged 1 commit into from
May 14, 2024

Conversation

PRATHAM2002-DS
Copy link

@PRATHAM2002-DS PRATHAM2002-DS commented May 14, 2024

Change description

The users successfully updated CM on a sub-domain without requiring the persona-domain-sub-domain-business-update-metadata permission. The PR includes policy adjustments for access control regarding custom metadata.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Copy link

@sumandas0 sumandas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

@nikhilbonte21 nikhilbonte21 merged commit 70a628e into master May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants