Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify message queue configuration #143

Merged
merged 12 commits into from
Jun 12, 2024
Merged

Conversation

sajith
Copy link
Member

@sajith sajith commented Jun 11, 2024

Resolves #137: gets rid of some environment variables (SUB_QUEUE, SUB_EXCHANGE, SUB_TOPIC), and use defaults instead.

We do not need a queue name. We do need an exchange name (which would be just "connection") to receive connection/link messages published by SDX-Controller. SUB_TOPIC is not really ever used.

This is stacked on top of #142; please review that PR first.

@coveralls
Copy link

Coverage Status

coverage: 77.465% (-0.02%) from 77.481%
when pulling 48b6888 on 137.simplify-mq-configuration
into d6a0ac1 on main.

@sajith sajith merged commit 2c072aa into main Jun 12, 2024
5 checks passed
@sajith sajith deleted the 137.simplify-mq-configuration branch June 12, 2024 12:43
@coveralls
Copy link

coveralls commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9482732510

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 77.465%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_lc/main.py 0 1 0.0%
Totals Coverage Status
Change from base Build 9482708983: -0.02%
Covered Lines: 971
Relevant Lines: 1199

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify message queue configuration
3 participants