Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete connection #145

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Delete connection #145

merged 4 commits into from
Jun 12, 2024

Conversation

congwang09
Copy link
Contributor

@congwang09 congwang09 commented Jun 12, 2024 •
edited
Loading

Resolves: #125

Allow LC to receive delete connection message and delete connection.

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9485974272

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.465%
Totals Coverage Status
Change from base Build 9484735236: 0.0%
Covered Lines: 971
Relevant Lines: 1199
💛 - Coveralls

YufengXin
YufengXin approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
The next step is to test w/ Kytos

@YufengXin YufengXin assigned YufengXin and congwang09 and unassigned YufengXin Jun 12, 2024
sajith
sajith approved these changes Jun 12, 2024
View reviewed changes
sdx_lc/messaging/topic_queue_consumer.py Outdated Show resolved Hide resolved
sdx_lc/messaging/topic_queue_consumer.py Outdated Show resolved Hide resolved
sdx_lc/messaging/topic_queue_consumer.py Outdated Show resolved Hide resolved
congwang09 and others added 2 commits June 12, 2024 12:55
@congwang09 @sajith
Update sdx_lc/messaging/topic_queue_consumer.py
4c8846d 
Co-authored-by: Sajith Sasidharan <sajith@hcoop.net>
@congwang09 @sajith
Update sdx_lc/messaging/topic_queue_consumer.py
23b8496 
Co-authored-by: Sajith Sasidharan <sajith@hcoop.net>
@congwang09 congwang09 merged commit 3fdd855 into main Jun 12, 2024
8 checks passed
@congwang09 congwang09 deleted the delete-connection branch June 12, 2024 16:58
@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9486624717

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.465%
Totals Coverage Status
Change from base Build 9484735236: 0.0%
Covered Lines: 971
Relevant Lines: 1199
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9486623691

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.465%
Totals Coverage Status
Change from base Build 9484735236: 0.0%
Covered Lines: 971
Relevant Lines: 1199
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajith sajith sajith approved these changes

@YufengXin YufengXin YufengXin approved these changes

Assignees

@congwang09 congwang09

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Receive/handle deletion notifications from sdx-controller
4 participants
@congwang09 @coveralls @sajith @YufengXin