Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1-series overhaul #2

Closed
wants to merge 35 commits into from
Closed

1-series overhaul #2

wants to merge 35 commits into from

Conversation

Ambrevar
Copy link
Member

This is a pretty big overhaul of the library. Except from the README:

- Renamed =scheme-name= to =keyscheme= and =scheme= to =keyscheme-map=.
  It's more consistent and intuitive.  The previous naming was really confusing.
- All warnings have now their own conditions, see the =nkeymaps/conditions= package.
- =define-keyscheme-map= has a different syntax, it's now
  #+begin_src lisp
    (define-keyscheme-map "NAME-PREFIX" (:import OPTIONAL-KEYSCHEME-MAP-TO-IMPORT)
      KEYSCHEME BINDINGS...)
  #+end_src
- The predefined =keyscheme=s are now accessible from the =nkeymaps= package.
- New =default= =keyscheme= which is the new parent of other keyschemes
  (including =cua=), instead of =cua=.
- =*modifier-list*= is no longer exported.  Instead, both =keyscheme= and
  =keymap= have a =modifiers= slot for the modifiers they accept.
- Switched testing framework from =Prove= to =Lisp-Unit2=.
- Removed the =cl-str= dependency.

@jmercouris @aadcg @aartaka What do you think?
I'll also open a pull request for Nyxt to prepare for the 1.0.0 update.

@Ambrevar
Copy link
Member Author

Note: Looking at individual commits will help here :)

@aadcg
Copy link
Member

aadcg commented Jun 29, 2022

That's a big overhaul! Thanks.

Shouldn't the version be 1.0.0, instead of 1 in the .asd file? I'm also wondering why did you decide to move from prove to lisp-unit2.

I fixed a minor typo and pushed here.

Will we use the same git merge strategy we use in Nyxt?

Once this is merged, I'll update the guix package.

@Ambrevar
Copy link
Member Author

  1. It's "1" because it's incompatible with the previous tagged release but it's not 1.0.0 ready yet. I'll update that ASD version and tag the commit all at once, when we confirm this is ready.

  2. For the rationale behind the move to Lisp-Unit2, see Move from Prove to Lisp-Unit2 nyxt#2199 (comment).

  3. Yes, we can use the same git branching management as with Nyxt.

  4. Thanks!

@aadcg
Copy link
Member

aadcg commented Jun 29, 2022

All clear.

@aartaka
Copy link
Contributor

aartaka commented Jun 30, 2022

  1. It's "1" because it's incompatible with the previous tagged release but it's not 1.0.0 ready yet. I'll update that ASD version and tag the commit all at once, when we confirm this is ready.

For that, a more conventional (at least based on my limited experience of lurking around moder git repos) tag would be 1-beta1 or 1-pre-release-1 (as in Nyxt).

@Ambrevar
Copy link
Member Author

ASD only supports numbers.

@aadcg
Copy link
Member

aadcg commented Jul 3, 2022

I commited dd35d31 to fix ecd1557.

@Ambrevar
Copy link
Member Author

Ambrevar commented Jul 4, 2022

Merged with 23c6801.

1.0.0 is out! :)

@Ambrevar Ambrevar closed this Jul 4, 2022
@aadcg aadcg deleted the 1-series branch September 15, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants