Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt-buffer: urgent fixes #1212

Closed
3 tasks done
Ambrevar opened this issue Mar 17, 2021 · 7 comments
Closed
3 tasks done

prompt-buffer: urgent fixes #1212

Ambrevar opened this issue Mar 17, 2021 · 7 comments
Labels

Comments

@Ambrevar
Copy link
Member

Ambrevar commented Mar 17, 2021

  1. switch-buffer loses focus because follow-mode is on.
    We need to maintain focus on the input when following buffer.

  2. The bookmark-url related commands should pre-mark the tags of existing bookmarks (easy).

  3. (Not actually urgent) Element-hinting functions need a custom filter to match against the hints.

  4. Re-introduce tab-insert, especially for set-url.

@Ambrevar
Copy link
Member Author

@jmercouris Indeed, I cannot reproduce "3". I think the issue occurs when a title has the same word as a hint, e.g. at. The hint-source does not take any provision to match hint first, so I guess there is still an issue, but it's no longer urgent since it works most of the time.

@jmercouris
Copy link
Member

I would say that is a likely explanation, yes.

@Ambrevar
Copy link
Member Author

I've fixed the missing tab-insert.

For bookmark pre-marks, I've implemented it but it seems to work only rarely.
Any idea why?

@jmercouris
Copy link
Member

What are bookmark "pre-marks"?

@jmercouris
Copy link
Member

Do you mean pre-marked tags within the prompt buffer? Are they marked by not rendering as marked? Could it be that we need to run an update-display event after some processing?

@Ambrevar
Copy link
Member Author

Ambrevar commented Mar 18, 2021 via email

@Ambrevar
Copy link
Member Author

Fixed with 9d1b48d.
Moving the optional item to atlas-engineer/prompter#32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants