Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot turn off buffer preview in switch-buffer #1430

Closed
franburstall opened this issue May 19, 2021 · 8 comments
Closed

Cannot turn off buffer preview in switch-buffer #1430

franburstall opened this issue May 19, 2021 · 8 comments

Comments

@franburstall
Copy link
Contributor

Describe the bug

I would like to turn off the buffer preview in switch-buffer because it makes the buffer order for C-PageUp/Dn unpredictable.

I thought I would achieve this by configuring the follow-p slot of buffer-source to nil. This writes

(DEFINE-CONFIGURATION BUFFER-SOURCE
  ((PROMPTER:FOLLOW-P NIL)))

to auto-config.lisp but, even after restarting nyxt, this does not have the desired effect: I still have buffer preview in switch-buffer.

How do I switch off buffer preview?

Information

  • OS name+version: Debian-10
  • Graphics card and driver:
  • Desktop environment / Window manager name+version: EXWM
  • How you installed Nyxt (Guix pack, package manager, build from source): Source
  • Information from command copy-system-information:

Nyxt version: 2-pre-release-7-114-g8011f784
Renderer version: GI-GTK
Operating system kernel: Linux 4.19.0-16-amd64
Lisp implementation: SBCL 2.1.1
Features: (SLYNK WEBKIT2 WEBKIT2-2.30 WEBKIT2-PASTE-PLAINTEXT WEBKIT2-TRACKING
WEBKIT2-MUTE WEBKIT2-EMOJI WEBKIT2-MEDIA WEBKIT2-SANDBOXING GTK-3-22 GTK-3-20
GTK-3-18 GTK-3-16 GTK-3-14 GTK-3-12 GTK-3-10 GTK-3-8 GTK-3-6 GTK-3-4 GTK
GDK-3-22 GDK-3-20 GDK-3-18 GDK-3-16 GDK-3-14 GDK-3-12 GDK-3-10 GDK-3-8 GDK-3-6
GDK-3-4 CAIRO-1-10 CAIRO-1-12 GDK-PIXBUF GLIB-2-30 GLIB-2-32 GLIB-2-34
GLIB-2-36 GLIB-2-38 GLIB-2-40 GLIB-2-42 GLIB-2-44 GLIB-2-46 GLIB-2-48
GLIB-2-50 GLIB-2-52 GLIB-2-54 GLIB-2-56 GLIB-2-58 GLIB NYXT-2 FSET-EXT-STRINGS
CUSTOM-HASH-TABLE-NATIVE SWANK PLUMP-UTF-32 GLOBAL-VARS DECLARE-TYPES
PARENSCRIPT NAMED-READTABLES 21BIT-CHARS CHUNGA FLEXI-STREAMS CLOSER-MOP
CL-PPCRE-UNICODE CL-UNICODE CL-PPCRE BORDEAUX-THREADS SPLIT-SEQUENCE
GRAY-STREAMS FAST-IO-SV FAST-IO SBCL-USES-SB-ROTATE-BYTE
ASDF-SYSTEM-CONNECTIONS CL-JSON-CLOS CL-JSON THREAD-SUPPORT FLAT-NAMESPACE
X86-64 UNIX CFFI FLAT-NAMESPACE SEQUENCE-EMPTYP QUICKLISP ASDF3.3 ASDF3.2
ASDF3.1 ASDF3 ASDF2 ASDF OS-UNIX NON-BASE-CHARS-EXIST-P ASDF-UNICODE X86-64
GENCGC 64-BIT ANSI-CL COMMON-LISP ELF IEEE-FLOATING-POINT LINUX LITTLE-ENDIAN
PACKAGE-LOCAL-NICKNAMES SB-LDB SB-PACKAGE-LOCKS SB-THREAD SB-UNICODE SBCL UNIX)

ASDF version: 3.3.1
Critical dependencies: (/home/fran/common-lisp/nyxt/_build/submodules/cl-cffi-gtk/gtk/cl-cffi-gtk.asd
/home/fran/common-lisp/nyxt/_build/quicklisp-client/dists/quicklisp/software/cl-gobject-introspection-20210124-git/cl-gobject-introspection.asd
/home/fran/common-lisp/nyxt/_build/submodules/cl-webkit/webkit2/cl-webkit2.asd)

Quicklisp dist version: 2021-04-11
Quicklisp client version: 2020-01-04
Local project directories: (/home/fran/common-lisp/nyxt/_build/submodules/
/home/fran/common-lisp/nyxt/_build/quicklisp-client/local-projects/)
Critical dependencies(#<SYSTEM cl-cffi-gtk / cl-cffi-gtk-20201220-git / quicklisp 2021-04-11>
#<SYSTEM cl-gobject-introspection / cl-gobject-introspection-20210124-git / quicklisp 2021-04-11>
#<SYSTEM cl-webkit2 / cl-webkit-20210411-git / quicklisp 2021-04-11>)

@Ambrevar
Copy link
Member

Ambrevar commented May 19, 2021 via email

@franburstall
Copy link
Contributor Author

I'll investigate. Note that you can disable 'follow-mode' interactively with C-c C-f.

Thanks, that is helpful. But C-c C-f doesn't persist to the next invocation of switch-buffer. Moreover, there is a single "follow" before you can do C-c C-f which inserts that buffer between source and target in the last-access ordered buffer-list.

@Ambrevar
Copy link
Member

That C-c C-f is not persisted is normal, there is no option for it at the moment.
I've added an entry to remember to implement it here: atlas-engineer/prompter#32

Do you know the resume-prompt command? If you resume a prompt its whole state is remembered, including follow-mode. Depending on the prompt, the list of suggestions might not be up-to-date though. This is by design.

@Ambrevar
Copy link
Member

To be really useful, resume-prompt would need a binding. Any suggestion?

@franburstall
Copy link
Contributor Author

To be really useful, resume-prompt would need a binding. Any suggestion?

C-c C-r?

@Ambrevar
Copy link
Member

Let's keep thinking about it in atlas-engineer/prompter#32.

This issue is fixed with a276091.
Thanks again for your support!

@jmercouris
Copy link
Member

I've also updated switch-buffer to not set current-buffer is last. This was annoying me as well. It would constantly shift my buffers when I was doing switch buffer. Therefore, Fran, you should be able to just use normal switch buffer now with the preview.

@franburstall
Copy link
Contributor Author

@jmercouris: I will give this a go. That said, I rather enjoy the no-fuss of having the preview switched off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants