plaintext-editor-mode should be defined in plaintext-editor-mode package

[aadcg]

For all of our modes, the mode and package names coincide. The only exception is plaintext-editor-mode, which is defined in the package of its parent mode - editor-mode.

Notice that it contrasts with the case of repeat-mode. It inherits from process-mode, but it is defined in repeat-mode, not process-mode.

I suggest renaming the package where plaintext-editor-mode is defined to plaintext-editor-mode.

[Ambrevar]

No strong opinion but makes sense!

[aartaka]

For all of our modes, the mode and package names coincide. The only exception is plaintext-editor-mode, which is defined in the package of its parent mode - editor-mode.

Another case like that is nyxt/style-mode:dark-mode.

Notice that it contrasts with the case of repeat-mode. It inherits from process-mode, but it is defined in repeat-mode, not process-mode.

Yes, a good reasoning it is. Derived modes that have features of their own should probably be in their own packages.

I suggest renaming the package where plaintext-editor-mode is defined to plaintext-editor-mode.

nyxt/plaintext-editor-mode, to be picky :P

[aadcg]

@aartaka all good observations, thanks. I absolutely missed nyxt/style-mode:dark-mode since, naively, I expected that a single mode is defined per file.